[TheGreatAxios]

Summary

• The secret-scrub classifier redacts bare-KEY env assignments (OPENAI_KEY, STRIPE_KEY) with a word-boundary guard so plain words like MONKEY stay readable
• Credential-bearing connection strings (DATABASE_URL and friends) redact only when the value carries credentials, leaving benign sqlite paths untouched

Verification

• Scrub suite: 23/23 pass (bun test src/plugins/tool-result-secret-scrub.test.ts)
• Consumer sweep: 121 pass (prior review verification)
• Typecheck note: repo tsc --noEmit reports a pre-existing vendor/intx-types semver-module error unrelated to this diff; no type errors in the touched plugin files

Merge before #1471 (that PR's JSON coverage builds on this ENV coverage).

Fixes CL-10756

[linear-code]

CL-10756

[corbits-triage]

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

[TheGreatAxios]

Review · Request changes

Env assignment scrubbing is one change, and it does not duplicate the JSON key scrub. Two holes in the new matcher.

Findings

• src/plugins/tool-result-secret-scrub.ts:41 — any @ after :// counts as userinfo. REGISTRY_URL=https://registry.npmjs.org/@scope/pkg and SUPPORT_URL=https://example.com/help?email=dev@example.com are wiped. The comment says only scheme://user:pass@host and password= should match.
• src/plugins/tool-result-secret-scrub.ts:94 — the replacer searches for the key from the right. OPENAI_KEY=proj-OPENAI_KEY-live-value-9z keeps the prefix through the second key. Redact the captured value.
• src/plugins/tool-result-secret-scrub.ts:42 — password= is never reached when the value has no ://. DATABASE_URL=Server=db;Password=s3cret; stays in the clear.

[TheGreatAxios]

Review · Approve

Env assignment scrubbing redacts scheme://user:pass@host and Password= DSNs, and leaves scoped npm URLs and email-query URLs alone. A value that contains its own key is fully redacted.

No findings.