Repository navigation
fix(mcp): fail in-flight calls when resume exhaustion redials - #1477
Merged
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Not Ready
Triage: Needs Human Review
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Request changes
Three behavior changes in one diff: the Codex 429 retry floor, MCP SSE resume exhaustion, and the same-origin redirect pin. Triage already failed the mix. The session.ts note is a comment-only drive-by.
Findings
src/mcp/client.ts:453—disarmTransportDeathSignalnoopsonclosebeforeProtocol.close. Resume exhaustion still redials, but an in-flight HTTP call stays pending until the SDK request timeout. Stdio death fails that call becauseonclosealready ran. The new tests drive a plain object, so they miss this.
Leave the SDK onclose wrapper in place so Protocol._onclose rejects an in-flight HTTP request with MCP -32000 when resume exhaustion redials.
TheGreatAxios
force-pushed
the
cl-10758-provider-mcp-residuals
branch
from
October 17, 2026 01:39
f111055 to
cfbc014
Compare
TheGreatAxios
changed the title
corbits-triage
Bot
added
Triage: Needs Human Review
Triage: Ready
and removed
Triage: Not Ready
Triage: Needs Human Review
labels
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Resume exhaustion still redials, and an in-flight HTTP call rejects with connection closed instead of staying pending. The diff is only that slice.
No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resume exhaustion still notifies the owner to redial, and an in-flight HTTP request rejects with MCP error -32000 (Connection closed) because close no longer replaces the SDK onclose wrapper.
Part of CL-10758