Repository navigation
refactor(session): drop the run.json snapshot debounce - #1484
Merged
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Request changes
The timer is gone. Turn boundaries write running immediately, and rotation still writes done then running.
Findings
src/tui/runner/session.ts:179—void persistRunSnapshot("running")does not catch a rejectingsaveState. The debouncer used to.installCrashHandlerstreats that rejection as fatal, so a mid-run snapshot IO error crashes the TUI. Exec already catches insidepersist. Catch inpersistRunSnapshotthe same way, and add a test that this call does not surfaceunhandledRejection.
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Request changes
The timer is gone. Turn boundaries write running immediately, and rotation still writes done then running.
Findings
src/tui/runner/session.ts:179—void persistRunSnapshot("running")does not catch a rejectingsaveState. The debouncer used to.installCrashHandlerstreats that rejection as fatal, so a mid-run snapshot IO error crashes the TUI. Exec already catches insidepersist. Catch inpersistRunSnapshotthe same way, and add a test that this call does not surfaceunhandledRejection.
TheGreatAxios
changed the base branch from
cl-10774-drop-snapshot-skip
to
main
October 17, 2026 03:13
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
The 5-second snapshot timer and its flushes are gone. Turn boundaries write running immediately. A failed saveState is logged and does not crash the process. Rotation still writes done, then running.
No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn-boundary snapshots write running immediately; the 5s debounce and its flushes are gone.
Fixes CL-10776