Repository navigation
test: drop hollow prompt and span pins - #1490
Merged
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Request changes
The hollow pins are gone. isSameTool, resolveModelFamilyPolicy, the grok prefix test, and the reactor-span observer tests remain.
Findings
src/agent/prompt-sizes.ts:203—directorPromptSizeTableis only imported by the deleted size-budget describe. Knip andcheck:dead-exportsboth flag it. Delete the export. KeepassembleDirectorPromptandcanonicalToolNamesForDirector; the grok-prefix test still uses them.packages/prompt-fragments/src/cards.ts:296—proberCardno longer namesassert-spans.ts. That string is shipped prompt prose, not a comment about the deleted hash pin. Put it back. This PR should not change a director prompt.
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
The hollow pins are gone. directorPromptSizeTable is gone. proberCard matches main again, including the assert-spans.ts line. The grok prefix, isSameTool, and resolveModelFamilyPolicy tests remain.
No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop hollow prompt and span pins that production never runs.
Fixes CL-10780