Repository navigation
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
The live-turns read went through the isogit base's load(), which also validates metadata.json against the vendor shape. This store writes token usage to the sidecar instead, so every cold load failed that validation, warned, and re-parsed turns.jsonl from disk. Parse the base segment directly; metadata already has its own lenient reader that still warns on a malformed document. Relaxing the vendored schema would add a ledgered patch for a file the base store no longer owns.
bwachman
force-pushed
the
cl-10769-stop-the-base-context-store-failing-every-load-on-missing
branch
from
October 17, 2026 03:54
fa6f3ab to
e7098aa
Compare
TheGreatAxios
approved these changes
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
There was a problem hiding this comment.
Review · Approve
Stops the spurious base-store warning on every session load by parsing turns.jsonl directly instead of routing through the isogit base's vendor-shape metadata validation.
Findings
No findings.
bwachman
deleted the
cl-10769-stop-the-base-context-store-failing-every-load-on-missing
branch
October 17, 2026 05:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turns.jsonlsegment directly instead of going through the isogit base store'sload(). That call validatedmetadata.jsonagainst a shape that requirestokenUsage, which now lives in thetoken-usage.jsonlsidecar, so every load loggedbase context store load failed; recovering base segment from diskand parsed turns twice.metadata.jsonstill warns, through the store's own metadata reader, and now warns once instead of twice. A torn final line in the base segment is dropped the same way extra segments already handle one.signalparameter on the live-turns read and the store'sloadis gone.Verification
bun run checkandbun run testpass, and the test output contains norecovering base segmentwarningstokenUsage must be an objectwarning, and a duplicated malformed-metadata warning) and pass on this branchFixes CL-10769
Part of CL-10763