Repository navigation
fix(reactor): open a message run when an approval resumes a parked call - #1496
Merged
TheGreatAxios merged 1 commit intoOct 17, 2026
Conversation
A run opens only when the loop dequeues message.received, and a correlated approval never becomes one. A parked call rehydrated by a new reactor has no run from the process that parked it, so its approval re-dispatched the call and re-inferred with no run open, and consumers that treat no open run as idle could rebuild the agent under the running continuation. The approval now opens a run keyed on its own message id when none is open. A resume inside the still-open parking run is unchanged.
TheGreatAxios
commented
Oct 17, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Approve
Opens a message run keyed on the approval's message id when a rehydrated parked call resumes with no run open, so idle-detectors can't rebuild the agent mid-continuation.
Findings
vendor/intx-inference/src/reactor.ts:842— follow-up to consider: thegate-clearedexclusion is correct for re-dispatched or answered parked calls, but a rehydrated async marker (no suspended call) resumed after restart still re-infers via the gate-cleared path with no run open. Pre-existing shape, not a regression; suggest either extending the open to that rail when no run is open or recording why the async rail is safe, with a mirroring test.
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
merged commit Oct 17, 2026
e1aedf3
into
cl-10765-never-inject-a-timeout-result-for-a-parked-call-that-already
13 checks passed
TheGreatAxios
deleted the
cl-10777-open-a-message-run-when-an-approval-resumes-a-parked-call
branch
October 17, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message.run.startedandmessage.run.endedevents.corbits resumepreviously ran an approved call with no open run. The TUI's reload deferral from fix(tui): defer agent reload until the reactor's message run ends #1486 keys on those events, so it could rebuild the agent mid-call on that path.Stacked on #1492 (which is stacked on #1485); review those first. The diff against its branch is this change only.
Verification
bun run checkpasses (9208 tests, 0 fail)Fixes CL-10777
Part of CL-10763