Repository navigation
perf(types): import runtime values from runtime-core - #1505
Merged
TheGreatAxios merged 2 commits intoOct 18, 2026
Merged
TheGreatAxios merged 2 commits into
TheGreatAxios merged 2 commits into
Conversation
Value imports of runtime contracts were loading the runtime barrel, which constructs the InferenceEvent union. Import those values from runtime-core instead.
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
commented
Oct 18, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Comment
Value imports that load at boot now come from @intx/types/runtime-core, and the session probe fails if those modules still evaluate inference-events.
Findings
No findings.
Six test files had been switched to runtime-core even though they are not on the boot path. Those specifier edits are reverted in f5f7f02f. runtime still re-exports the same symbols.
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContentBlock,TokenUsage,ToolCall, and the other runtime values those modules execute) come from@intx/types/runtime-core, so loading them does not construct the InferenceEvent union.@intx/types/runtimestay. They erase and do not evaluate the union.Verification
bun run checkpassesinference-eventsevaluates; importing the runtime barrel still trips that probeFixes CL-10808