Repository navigation
fix(tui): cap mcp connect so a hung dial cannot block resume - #1507
Merged
TheGreatAxios merged 3 commits intoOct 18, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
A startup dial with no handshake cap never settles, so a persisted workflow cannot resume while one server hangs. Bound each TUI dial the same way headless does, and report the timeout as a failed server without aborting a sibling that already connected.
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
The dial cap aborts every in-flight handshake, including one that already showed an auth URL. Drop that abort for the browser wait so the existing auth budget remains, and still fail a dial that never reaches auth.
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
TheGreatAxios
commented
Oct 18, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Comment
A hung non-auth MCP dial fails on the 15s cap, and that cap starts only after trust filtering. Browser auth still drops the dial abort.
Findings
No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run checkpassesFixes CL-10814