Repository navigation
perf(permission): defer the grok responses import off reactor boot - #1516
Merged
TheGreatAxios merged 3 commits intoOct 18, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
TheGreatAxios
commented
Oct 18, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review · Comment
Importing the permission reactor no longer evaluates the InferenceEvent union. Name checks for xai/ and codex/ stay local so those provider barrels are not loaded at boot.
Findings
No findings.
The createRequire loads of package constants.js and oauth.js are gone. The net diff is three files: the runtime-core import, the inlined prefix checks, and the boot probe.
TheGreatAxios
marked this pull request as ready for review
October 18, 2026 03:30
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Ready
Triage: Waiting for CI
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InferenceEventunion through the grok and OpenAI responses import chain.Verification
src/session/runtime-core-import.test.tsprobesreactor-authorizewith@intx/types/inference-eventsmocked to throw and expects exit 0.Fixes CL-10829