[TheGreatAxios]

Summary

• Config, profile, task, and run-state arktype schemas are built on first read instead of at import, so a malformed file still fails at the read that used to fail and not merely because the module loaded.
• The session store dynamically imports the node isogit entry when a session is opened. vendor/ is unchanged.
• boot and first-paint spans start at boot and end when the TUI host mounts, so that interval can be told apart from import-time work.

Test plan

• bun test src/config/settings-lazy.test.ts src/session/isogit-boot.test.ts src/perf/boot-spans.test.ts src/config/settings.test.ts src/agent/tasks.test.ts src/plugins/data-only-agent.test.ts (80 pass)
• tsc --noEmit via the pre-commit hook

[linear-code]

CL-10809

[corbits-triage]

Triage: Fail

@TheGreatAxios, please address the following:

• required checks are failing: static-analysis

[TheGreatAxios]

Review · Request changes

Schemas and the isogit store wait until first use. A bad settings file still fails at the read. vendor/ is untouched. exec and onboarding never close the boot spans, and a few comments restate the ticket.

Findings

• src/index.ts:40 — boot and first-paint start here and only end in mountRunnerHost. exec and onboarding never mount that host, then flushPerfToOtel exports the open spans with no end time. Close them before that flush on every path that does not mount the TUI.

• src/session/isogit-node.ts:10 — isogitNodeLoadStarted has no callers. Delete it.

• src/schema/lazy.ts:1, src/perf/boot-spans.ts:3, src/session/isogit-node.ts:1 — these comments restate the ticket. The note that lazyCallable must not be passed into type() should stay.

• src/config/settings-lazy.test.ts:16 — the test pins /Invalid settings schema/. Assert that a bad settings file fails at read, not the sentence.

[TheGreatAxios]

Review · Comment

The prior findings are gone. exec closes the boot spans before the perf flush, the dead export and ticket comments are gone, and the settings test no longer pins the error sentence. The deferral still holds.

Findings

No code findings on 2420b766. CI is red: oxfmt wants src/config/settings.ts formatted, and src/session/isogit-boot.test.ts leaves a throw installed (session open reached isogit) that fails later tests in the same process. Restore the real module with withMockedModule.

[TheGreatAxios]

Review · Approve

Schemas and the isogit store wait until first use. exec closes the boot spans before the perf flush. The dead export, ticket comments, and pinned error sentence are gone. oxlint, oxfmt, dead exports, and the test shards passed on 37078219.

Findings

No findings.