Repository navigation
chore(build): ignore leftover bun compile artifacts - #1565
TheGreatAxios merged 1 commit into
Conversation
c72dca0 to
c35b042
Compare
TheGreatAxios
left a comment
There was a problem hiding this comment.
Fleet review verdict: APPROVE
PR: #1565 — chore(build): ignore leftover bun compile artifacts (CL-11358)
Convergence: swarm → defect / quality / solve convergence → all converged approve (unanchored-pattern nit accepted as non-blocking).
Outcome
Fix verified (*.bun-build ignore rule vs Bun 1.4.2 compile behavior); no blocking findings.
Required changes
None blocking. Flagged for operator disposition.
TheGreatAxios
left a comment
There was a problem hiding this comment.
Fleet review verdict: REQUEST CHANGES
PR: #1565 — chore(build): ignore leftover bun compile artifacts (CL-11358)
Operator disposition update: the prior "approve" posture is withdrawn; this PR is converted to REQUEST CHANGES with the remaining nit carried.
Requested changes
- N1 (nit):
*.bun-buildgitignore pattern is unanchored (root-scoped intent would warrant anchoring).
Required changes to merge
Address the requested change above (or explicitly close it) before merge.
Why it matters
Non-blocking item remains; operator opted for a stricter review posture.
c35b042 to
f280f2b
Compare
|
|
Resolved findings at
|
TheGreatAxios
left a comment
There was a problem hiding this comment.
Re-reviewed at f280f2b. The ignore is root-anchored and still matches Bun's compile scratch file. Approving.
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
Summary
*.bun-build, the roughly 87 MB copy of the bun executable thatbun build --compile(such asbun run build:bin) leaves in the checkout root on each run, so it no longer shows ingit statusas an untracked file and makes a clean worktree look dirty.Verification
bun run build:binruns each add one.<hash>-00000000.bun-buildfile;git check-ignore -vmatches it against the new rule andgit status --shortstays clean.gitignoreFixes CL-11358