Skip to content

chore(build): ignore leftover bun compile artifacts - #1565

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-11358-ignore-leftover-bun-compile-artifacts-in-git-status
Oct 25, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-11358-ignore-leftover-bun-compile-artifacts-in-git-status

Conversation

@bwachman

@bwachman bwachman commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Ignores *.bun-build, the roughly 87 MB copy of the bun executable that bun build --compile (such as bun run build:bin) leaves in the checkout root on each run, so it no longer shows in git status as an untracked file and makes a clean worktree look dirty.

Verification

  • Two consecutive bun run build:bin runs each add one .<hash>-00000000.bun-build file; git check-ignore -v matches it against the new rule and git status --short stays clean
  • The pre-commit hook (typecheck and build) passes; the change touches only .gitignore

Fixes CL-11358

@linear-code

linear-code Bot commented Oct 24, 2026

Copy link
Copy Markdown

CL-11358

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet review verdict: APPROVE

PR: #1565 — chore(build): ignore leftover bun compile artifacts (CL-11358)

Convergence: swarm → defect / quality / solve convergence → all converged approve (unanchored-pattern nit accepted as non-blocking).

Outcome

Fix verified (*.bun-build ignore rule vs Bun 1.4.2 compile behavior); no blocking findings.

Required changes

None blocking. Flagged for operator disposition.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet review verdict: REQUEST CHANGES

PR: #1565 — chore(build): ignore leftover bun compile artifacts (CL-11358)

Operator disposition update: the prior "approve" posture is withdrawn; this PR is converted to REQUEST CHANGES with the remaining nit carried.

Requested changes

  • N1 (nit): *.bun-build gitignore pattern is unanchored (root-scoped intent would warrant anchoring).

Required changes to merge

Address the requested change above (or explicitly close it) before merge.

Why it matters

Non-blocking item remains; operator opted for a stricter review posture.

@bwachman
bwachman force-pushed the cl-11358-ignore-leftover-bun-compile-artifacts-in-git-status branch from c35b042 to f280f2b Compare October 24, 2026 20:49
@bwachman

Copy link
Copy Markdown
Contributor Author
  • Unanchored *.bun-build pattern: fixed. The rule in .gitignore is now /*.bun-build, anchored to the repository root. Bun leaves the artifact in the directory bun build --compile runs from, and both build:bin in package.json and scripts/release.sh (after cd "$ROOT") compile from the root. The comment above the rule now says so.

@bwachman

Copy link
Copy Markdown
Contributor Author

Resolved findings at f280f2bb, with line citations

Finding Status Where
N1: unanchored *.bun-build Resolved The rule is now /*.bun-build, with a comment saying why it is root-only (.gitignore:19-21). git check-ignore -v .5f144b97a4287904-00000000.bun-build matches .gitignore:21 at the root, and the same name under a subdirectory is not matched.

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at f280f2b. The ignore is root-anchored and still matches Bun's compile scratch file. Approving.

@corbits-triage

Copy link
Copy Markdown
Contributor

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

@TheGreatAxios
TheGreatAxios merged commit ed0565f into main Oct 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants