Repository navigation
fix(reactor): keep rejected and timed-out approval results across a rebuild - #1575
Conversation
The tool-cycle coalescing patch defers the cycle commit to the next terminal, and only executeTools wrote turns in between. A rebuild after a rejection or timeout but before that terminal reloaded the call as still parked with no result, and the next request sent an unanswered tool call.
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
left a comment
There was a problem hiding this comment.
Review · Approve
Persists rejection and timeout results before cycle commit and flushes accepted negative decisions during reactor shutdown.
No findings.
Reviewed 31a5741144b7b9d15d249d2c16830d08cfaa2754 against main. The scoped permission lens found no additional trust findings; that assessment was static, not a general race-safety guarantee.
Verification: bun test vendor/intx-inference/src/reactor.test.ts e2e/reactor-approval-reload.test.ts: 206 passed. Adjacent acceptance/parked-call settlement suites: 30 passed. A temporary timeout-behind-inference/shutdown reproduction passed and was removed. bun run check output completed through the guarded suite with 9,502 passed, 0 failed; the background wrapper's final numeric exit status was not surfaced. Validation covers graceful shutdown/rebuild, not power-loss durability or generic upstream-store compatibility.
Summary
Verification
bun run checkpasses on each commit (9502 tests at the tip)Related to CL-11433