Skip to content

feat: map interchange's neutral effort to codex reasoning.effort - #34

Merged
TheGreatAxios merged 1 commit into
feat/account-id-quirkfrom
feat/map-inference-effort
Oct 29, 2026
Merged

TheGreatAxios merged 1 commit into
feat/account-id-quirkfrom
feat/map-inference-effort

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Closes #33

Stacked on #32 (base feat/account-id-quirk).

What changed

Verification

  • bun run check (typecheck, lint, format, 21 unit tests) passes.
  • New tests pin the per-model max, the unlisted-model fallback, and option precedence (non-empty wins, none suppresses, empty falls through).
  • Independent review findings addressed (empty-option precedence, comment accuracy, return type, tests, docs).

max sends the highest level each model lists in the Codex CLI catalog (openai/codex@b1e72963c3, supported_reasoning_levels), else high. An explicit codexReasoningEffort option still wins.
@TheGreatAxios
TheGreatAxios force-pushed the feat/map-inference-effort branch from a9a28cf to 5db2070 Compare October 29, 2026 19:39
@TheGreatAxios
TheGreatAxios changed the base branch from main to feat/account-id-quirk October 29, 2026 19:39
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review October 29, 2026 19:41
@corbits-triage

corbits-triage Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Stacked on #32: only this pull request's own changes were checked.

Triage will approve, request review.

@TheGreatAxios
TheGreatAxios merged commit 1d2215a into feat/account-id-quirk Oct 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map Interchange's neutral effort to Codex reasoning.effort

1 participant