Repository navigation
feat!: run evals with one runEvaluation call - #23
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
TheGreatAxios
commented
Oct 27, 2026
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Review · Approve
Replaces the eval entrypoint with one runEvaluation call (task, data, scorers).
Findings
No findings.
src/evaluate.ts is gone. In-repo call sites, examples, and the README use runEvaluation. The remaining evaluate import is @corbits/system-one in src/jev.ts, not the old entry. Passing a previous Report as compare is a type error (Report.cases is not an Experiment). bun test e2e src exited 0 (54 pass) and bun run typecheck exited 0.
This was referenced Oct 27, 2026
Merged
Contributor
Author
Contributor
Author
|
Superseded by the 0.2.0 release: #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evaluate(name, options)withrunEvaluation({ name, data, task, scorers }).Evaluation. The saved comparable result is anExperimentat format 2. Format 1 is rejected.Report.checksandcalibrate's public signature stay. The JSONLexpectfield stays for a later rename.Verification
bun run checkexited 0 (typecheck, oxlint, oxfmt, 1 unit test, 53 e2e tests).0f62edefound no defects.Fixes CL-11496