Repository navigation
fix(send): flag the Sent copy undelivered when deliver fails - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-9914
Problem:
POST /me/inbox/sendfiles the Sent copy, then awaitsdeliver. Whendeliverthrows (e.g. 409 because the recipient run finished) the request fails, but the Sent copy is indistinguishable from a delivered one.Fix: append-before-deliver is unchanged. On a
deliverfailure the Sent message gets the existing-column flag$Undelivered(no schema change), anundeliveredevent is published, the failure is logged, and the original error is rethrown so its HTTP status is preserved. The flag shows in the existingflagsof list, read and thread responses.UNDELIVERED_FLAGis exported.Reproduced: new e2e tests in e2e/mount-send.test.ts failed before the fix (no flag, no event) and pass after.
Gates:
bun run checkandbun run test:e2epass.