Repository navigation
fix(triage): keep the verdict label while a new commit is checked - #374
Merged
TheGreatAxios merged 1 commit intoOct 19, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-10913-keep-a-pull-requests-triage-label-steady-while-a-new-commit
branch
2 times, most recently
from
October 19, 2026 17:36
f4fb6cf to
cdbf362
Compare
TheGreatAxios
changed the base branch from
cl-10905-wait-for-pending-ci-instead-of-posting-unsure-and-say-why
to
main
October 19, 2026 17:39
TheGreatAxios
force-pushed
the
cl-10913-keep-a-pull-requests-triage-label-steady-while-a-new-commit
branch
from
October 19, 2026 17:47
cdbf362 to
8cfbed6
Compare
TheGreatAxios
marked this pull request as ready for review
October 19, 2026 17:47
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-10913
What changed
keeplist and leaves labels alone while the pull request carries any of them. The waiting marker keeps "Triage: Not Ready" and "Triage: Needs Human Review" (the policy's fail and unsure labels), so a push changes no label unless the verdict changes, and then it is swapped once.noCiand the marker only takes Ready off. A run that waits on a head with no checks does the same.unreadystep: the mirror takes Ready off that head (effect idunready:<repo>:<number>:<head>) before facts are read. Ready is gone as soon as the run starts, even where the policy does not wait for CI; the verdict puts it back if the head passes.How it was verified
bun run check; triage-workflows, github-tool, triage-contracts and the hub's non-Postgres github tests: 557 pass.noCi. Each fails with its part of the change taken out.