Repository navigation
feat: send x-grok-user-id from the source's quirks - #40
Merged
Merged
Conversation
An Interchange catalog source carries no providerOptions, so a deployment can now state the user id as quirks.userId. A per-call option still overrides it. Unknown quirk keys, previously ignored, are now rejected.
TheGreatAxios
force-pushed
the
feat/user-id-quirk
branch
from
October 29, 2026 19:40
9c5b6b2 to
d66e84e
Compare
TheGreatAxios
marked this pull request as ready for review
October 29, 2026 19:41
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve, request review. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Waiting for CI
labels
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
What changed
createXaiResponsesAdapterparses per-source quirks as{ userId? }(visible ASCII only) and sendsuserIdas thex-grok-user-idstatic header. Without one, the adapter is built from the module-level factory as before.providerOptions[XAI_USER_ID_OPTION]still overrides it per call.Verification
bun run check(typecheck, lint, format, 5 unit tests) passes.