Repository navigation
feat: add a sidebar search control that opens the palette - #136
Merged
Merged
Conversation
Contributor
Author
Storybook · before and after
Gist: https://gist.github.com/TheGreatAxios/c5d7218fe0f123a29fce6a1bd22eaf3d ExpandedSearch and Cmd+K. Before and after are the same image. CollapsedThe label and the hint drop out. The search icon stays. Before and after are the same image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Adds
SidebarSearch, a rail control labelled Cmd+K. A click, or Cmd+K / Ctrl+K, callsonOpenso the host can open the existingCommandPalette. The row usesSidebarItemstyling and collapses to the search icon. Collapse stays a prop onSidebar. No new context and no new dependency.The issue says the palette is built on TanStack's key handling. That loses to the recorded decision: the listener stays in
command-palette.tsx(useCommandShortcut), and this control calls it. No TanStack hotkeys package.Import it from
@corbits/react-ui/ui/sidebar-search. It is not on the root barrel, because the palette module loads the optional dialog peer.Verification
bun run typecheckpassedbun run lintpassedbun run format:checkpassedbun test src: 248 pass, 0 failbun run dep-guardpassedRelease
Not published. Version stays 0.3.1. A version bump here is the release itself, so this pull request does not bump.
The corbits-triage portal pull request is waiting on an owner release of the new exact version. It was not opened.
Refs CL-11569