Repository navigation
feat(tooltip): add general Tooltip and rebuild InfoTooltip on it - #162
Merged
TheGreatAxios merged 1 commit intoNov 2, 2026
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve. Changed since the last verdict (Fail at |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Not Ready
and removed
Triage: Waiting for CI
labels
- Export general Tooltip wrapping a focusable trigger element - Support custom label (ReactNode), side, delay, sideOffset, and open state - Rebuild InfoTooltip on top of Tooltip with identical rendered output and props - Add unit tests for Tooltip and update Storybook stories and README Closes CL-11941
TheGreatAxios
force-pushed
the
cl-11941-add-a-general-tooltip-to-corbitsreact-ui
branch
from
November 2, 2026 04:08
95cc5a4 to
3325314
Compare
corbits-triage
Bot
dismissed
their stale review
November 2, 2026 04:16
Nothing triage asked to change still fails, so this request no longer stands.
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
deleted the
cl-11941-add-a-general-tooltip-to-corbitsreact-ui
branch
November 2, 2026 04:20
Merged
TheGreatAxios
added a commit
that referenced
this pull request
Nov 2, 2026
Bump @corbits/react-ui from 0.5.0 to 0.5.1 for general Tooltip (#162). Closes CL-11941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a general
Tooltipto@corbits/react-ui/ui/tooltipthat wraps a focusable child trigger element, and rebuildsInfoTooltipon top ofTooltipwith zero visual change or regression.Closes CL-11941
Changes
Tooltip:React.ReactElement) as its trigger using Radix'sTooltipPrimitive.Trigger asChild.label(ReactNode),side("top" | "right" | "bottom" | "left"),delay(defaults to 200ms),sideOffset(defaults to 6px),defaultOpen,open,onOpenChange, andclassName.aria-describedbylinks trigger to content, Escape closes it.InfoTooltip:Tooltipwrapping the standard<InfoIcon>button trigger.stories/primitives/tooltip.stories.tsxwith examples of generalTooltiptriggers (Buttonvariants), placement sides, and rich labels alongside existingInfoTooltipstories.TooltipinREADME.mdcontrols table.scripts/agent-references.mjsautomatically documentsTooltipinskills/react-ui/references/controls.md.Verification
bun run check: typecheck (0 errors), oxlint (0 errors), oxfmt (clean), and unit tests pass.bun run dep-guard: clean (no leaks to root barrel; client boundaries match).bun run contrast-test: all pairs pass in light and dark.bun run build: successful compilation, CSS emission, and references generation.bun test ./e2e/exports.test.ts ./e2e/contrast.test.ts: passes.