Repository navigation
refactor: drop React 18 workarounds - #165
Open
pratikbuilds wants to merge 1 commit into
Open
pratikbuilds wants to merge 1 commit into
pratikbuilds wants to merge 1 commit into
Conversation
PanelPane passes `inert={!shown}` directly instead of a string `inert`
that React 18 kept. ConversationItem relies on React 19 running the
cleanup its ref callback returns, without the extra release ref for
React 18's null-ref detach.
Remove the test of that null-ref path and the test comments that
justify forwardRef checks by React 18.
Depends on corbitsdev#149, which narrows the peer range to React 19.
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
corbits-triage
Bot
added
Triage: Waiting for CI
Triage: Ready
and removed
Triage: Waiting for CI
labels
TheGreatAxios
approved these changes
Nov 4, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
Approving. Hidden panes use boolean inert, shown panes do not, and ConversationItem still unregisters through the ref-callback cleanup.
Merge this after #149. On a tree that still allows React 18, inert={false} leaves the attribute set and the ref cleanup is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PanelPane sets
inert={!shown}directly. A hidden pane stays inert; a shown pane does not. The React 18 stringinertworkaround is gone.ConversationItem returns the item-registry cleanup from its ref callback, so React 19 unregisters on detach. The React 18 null-ref release path and its test are gone. Unregister is still covered when an item rerenders out.
Does not change the React peer range (that is #149).
Closes #142