Repository navigation
test: drop class-string tests covered by browser specs - #62
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-9121-react-ui-delete-class-string-tests-for-indicator-components
branch
from
September 25, 2026 21:55
538358a to
139d3a6
Compare
TheGreatAxios
changed the title
TheGreatAxios
changed the base branch from
main
to
cl-9156-react-ui-run-axe-over-stories-build-in-place-of-aria-string
September 25, 2026 21:56
Merged
TheGreatAxios
force-pushed
the
cl-9121-react-ui-delete-class-string-tests-for-indicator-components
branch
from
September 26, 2026 00:07
a33cd87 to
6f6a11c
Compare
TheGreatAxios
changed the title
TheGreatAxios
force-pushed
the
cl-9121-react-ui-delete-class-string-tests-for-indicator-components
branch
from
September 26, 2026 01:32
6f6a11c to
0926f78
Compare
TheGreatAxios
changed the title
TheGreatAxios
force-pushed
the
cl-9121-react-ui-delete-class-string-tests-for-indicator-components
branch
from
September 27, 2026 19:08
0926f78 to
445ea32
Compare
TheGreatAxios
changed the title
Twelve unit test files mostly asserted class names and markup. The e2e specs and the axe sweep cover their behavior; motion.spec.ts adds the reduced-motion, forced-colors and paused checks.
TheGreatAxios
force-pushed
the
cl-9121-react-ui-delete-class-string-tests-for-indicator-components
branch
from
September 27, 2026 19:11
445ea32 to
0151cbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #71. Merge after the e2e stack so coverage never drops on main.
Summary
src/icon-tokens.test.ts; button, select, filter-chip, sidebar-item-row; rich-empty-state, block-card,blocks/login/auth-layout.e2e/motion.spec.ts: ShimmerText falls back to solid text under reduced motion and forced colors, ThinkingMark's echo drops its second wave under reduced motion, andpausedfreezes every animation.Verification
bun run check(239 pass),bun run buildandbun run test:e2e(21 Playwright tests) pass.Closes CL-9121
Closes CL-9123
Closes CL-9124