Repository navigation
fix: await router calls so unroutable trigger mail is not dropped - #24
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
TheGreatAxios
commented
Oct 7, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Review · Approve
The run-trigger deliverer awaits sendRunGrants and routeMail, so a router resolving false raises RunTriggerUnroutableError instead of accepting and dropping the mail.
No findings.
TheGreatAxios
deleted the
cl-10188-await-the-routers-routemail-so-unroutable-trigger-mail-is
branch
October 8, 2026 00:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Await
routeMailandsendRunGrantsin the run-trigger deliverer and type both asboolean | Promise<boolean>, so a router that resolvesfalseraisesRunTriggerUnroutableErrorinstead of being accepted and dropped.Added regression tests with async routers returning
falsefor each call; both failed before the fix.Verified with
bun run check(typecheck, lint, format, tests).