Repository navigation
refactor!: deliver run grants and trigger mail in one routeMail call - #25
Merged
TheGreatAxios merged 1 commit intoOct 8, 2026
Conversation
BREAKING CHANGE: `HookMailRouter` is replaced by `HookRouter` (`Pick<SidecarRouter, "routeMail">`); `RUN_GRANTS_NOT_ROUTABLE` and `RunTriggerUnroutableCode` are removed and `RunTriggerUnroutableError` takes `(address, runId)`. `@intx/hub-sessions` is a new peer dependency.
TheGreatAxios
deleted the
cl-10190-deliver-run-grants-and-trigger-mail-in-one-routemail-call
branch
October 8, 2026 00:48
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HookRouter,Pick<SidecarRouter, "routeMail">from@intx/hub-sessions(new peer dependency), replacing the hand-writtenHookMailRouter.routeMailcall withrunGrants, so grants and mail share one admission decision;sendRunGrantsis no longer used.RUN_GRANTS_NOT_ROUTABLEandRunTriggerUnroutableCodeare removed,RunTriggerUnroutableErrortakes(address, runId), andisRunTriggerUnroutableusesinstanceof.Verified with
bun run check(typecheck, lint, format, 48 unit tests) andbun run test:e2eagainst local Postgres (5 pass). Unit tests cover a router resolvingfalse,runGrantspassed in the single call, and one router call per delivery.