Repository navigation
ci(policy): run the corbits-triage rules and actions - #1146
Draft
TheGreatAxios wants to merge 4 commits into
Draft
TheGreatAxios wants to merge 4 commits into
TheGreatAxios wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the Corbits Triage policy file for this repository, a
policy-checkjob in CI that runs the policy checker on every pull request, and one line in CONTRIBUTING.md saying a pull request without a linked issue is closed.Size never holds a pull request: going over 25 files or 1,500 lines adds a
sizelabel and nothing else.A pull request without a linked issue is closed, for every author. Pass approves pull requests from thegreataxios and brianjfox. Everyone else, including pratikbuilds, gets a review request from thegreataxios. Unsure pull requests from maintainers are assigned to thegreataxios.
Measured on the last 50 merged pull requests:
vendor/intxin 143 file changes;bun.lockin 10 pull requestsRules beyond the starter:
focused: the decision model checks that a change does one thing.docs: the decision model checks that docs follow behavior changes.linked-issuewithtracker: either: requires a GitHub issue or a Linear key. Linear keys appear in 44 of 50 pull requests.conventional-commits: default types, the ones CONTRIBUTING.md lists.hidden-content: fails text hidden from reviewers.no-duplicateandduplicates-open-pull-request: stop two open pull requests for the same change from both going through.sensitive-paths: schema and auth changes are high, CI, lockfile and vendored changes are medium. AGENTS.md requires maintainer approval forvendor/intx.no-ai-attribution: asks on AI co-author lines, session trailers and generated-with footers in titles, descriptions and commits.conventions(code-patterns, convention preset, labels only): flags nested ternaries, IIFEs, promise chains, suppression comments and invented?? 0and?? []fallbacks. AGENTS.md bans fallbacks and promise chains; refactor(hub,sidecar): modularize hub composition and retire obsolete sidecar deltas (CL-10992, CL-10993) #1138 added a.thenchain and?? ""defaults.invented-fallbacks(code-patterns, labels only): flags an empty string,|| []or|| 0fallback in added TypeScript or JavaScript outside tests. Same patterns as corbitsdev/react-ui.no-any(code-patterns, asks): flags ananytype in added TypeScript outside tests.Waiting on you:
.corbits-triage.ymlalready existed on this branch's base. It is edited in place, not replaced. Its reasons that read "Set in the portal before the policy file" are replaced, and the 5,000-line limit is now 1,500. Confirm this is the intended change.The policy file validates with the policy checker (
corbits-triagepackages/policy-check-action). The new CI job is identical to the one in corbitsdev/react-ui, pinned to the same action commit.Closes CL-11544