Skip to content

ci(policy): run the corbits-triage rules and actions - #1146

Draft
TheGreatAxios wants to merge 4 commits into
mainfrom
cl-11544-run-the-corbits-triage-policy-on-workbench
Draft

TheGreatAxios wants to merge 4 commits into
mainfrom
cl-11544-run-the-corbits-triage-policy-on-workbench

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

This adds the Corbits Triage policy file for this repository, a policy-check job in CI that runs the policy checker on every pull request, and one line in CONTRIBUTING.md saying a pull request without a linked issue is closed.

Size never holds a pull request: going over 25 files or 1,500 lines adds a size label and nothing else.

A pull request without a linked issue is closed, for every author. Pass approves pull requests from thegreataxios and brianjfox. Everyone else, including pratikbuilds, gets a review request from thegreataxios. Unsure pull requests from maintainers are assigned to thegreataxios.

Measured on the last 50 merged pull requests:

Measure Value
Files changed, median / 90th percentile 7.5 / 23 (limit 25)
Lines changed, median / 90th percentile 259 / 1,450 (limit 1,500)
Titles in Conventional Commits form 29 of 50
Titles or descriptions naming a Linear key (CL-…) 44 of 50
Authors thegreataxios 45, pratikbuilds 4, a bot 1
Vendored or generated changes vendor/intx in 143 file changes; bun.lock in 10 pull requests

Rules beyond the starter:

  • focused: the decision model checks that a change does one thing.
  • docs: the decision model checks that docs follow behavior changes.
  • linked-issue with tracker: either: requires a GitHub issue or a Linear key. Linear keys appear in 44 of 50 pull requests.
  • conventional-commits: default types, the ones CONTRIBUTING.md lists.
  • hidden-content: fails text hidden from reviewers.
  • no-duplicate and duplicates-open-pull-request: stop two open pull requests for the same change from both going through.
  • sensitive-paths: schema and auth changes are high, CI, lockfile and vendored changes are medium. AGENTS.md requires maintainer approval for vendor/intx.
  • no-ai-attribution: asks on AI co-author lines, session trailers and generated-with footers in titles, descriptions and commits.
  • conventions (code-patterns, convention preset, labels only): flags nested ternaries, IIFEs, promise chains, suppression comments and invented ?? 0 and ?? [] fallbacks. AGENTS.md bans fallbacks and promise chains; refactor(hub,sidecar): modularize hub composition and retire obsolete sidecar deltas (CL-10992, CL-10993) #1138 added a .then chain and ?? "" defaults.
  • invented-fallbacks (code-patterns, labels only): flags an empty string, || [] or || 0 fallback in added TypeScript or JavaScript outside tests. Same patterns as corbitsdev/react-ui.
  • no-any (code-patterns, asks): flags an any type in added TypeScript outside tests.

Waiting on you:

  1. .corbits-triage.yml already existed on this branch's base. It is edited in place, not replaced. Its reasons that read "Set in the portal before the policy file" are replaced, and the 5,000-line limit is now 1,500. Confirm this is the intended change.

The policy file validates with the policy checker (corbits-triage packages/policy-check-action). The new CI job is identical to the one in corbitsdev/react-ui, pinned to the same action commit.

Closes CL-11544

@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown

CL-11544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant