Repository navigation
fix(mp3): keep external output encoder-only #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d86e1e8
docs(transcode): plan encoder-only MP3 output
gunwooterry 16ec61a
fix(mp3): keep the worker output encoder-only
gunwooterry 7be1028
test(mp3): retain the complete fixture CI commands
gunwooterry 05fc341
Merge remote-tracking branch 'origin/main' into fix/mp3-worker-output
gunwooterry 7fa017f
fix(mp3): refuse missing encoders across exit codes
gunwooterry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| //! Actual MP3 worker starts and output checked by the frozen compatibility tools. | ||
| #![cfg(all(unix, feature = "transcode"))] | ||
| #![allow(clippy::unwrap_used, clippy::panic)] | ||
|
|
||
| #[path = "../../../test-support/oracle.rs"] | ||
| mod test_oracle; | ||
|
|
||
| #[test] | ||
| fn mp3_worker_starts_and_output_pass_the_frozen_checks() { | ||
| let oracle = test_oracle::require(); | ||
| let root = std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("../.."); | ||
| let work = std::path::Path::new(env!("CARGO_TARGET_TMPDIR")).join("mp3-worker-protocol"); | ||
| if work.exists() { | ||
| std::fs::remove_dir_all(&work).unwrap(); | ||
| } | ||
| let result = std::process::Command::new("python3") | ||
| .arg(root.join("scripts/mp3_worker_check.py")) | ||
| .args(["--coreav", env!("CARGO_BIN_EXE_coreav"), "--work"]) | ||
| .arg(&work) | ||
| .env("COREAV_FFMPEG", oracle.ffmpeg()) | ||
| .env("COREAV_FFPROBE", oracle.ffprobe()) | ||
| .output() | ||
| .unwrap(); | ||
| assert!( | ||
| result.status.success(), | ||
| "{}{}", | ||
| String::from_utf8_lossy(&result.stdout), | ||
| String::from_utf8_lossy(&result.stderr) | ||
| ); | ||
| print!("{}", String::from_utf8_lossy(&result.stdout)); | ||
| std::fs::remove_dir_all(work).unwrap(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.