Repository navigation
perf(h264): shrink encoder tiles - #518
Conversation
Signed-off-by: Gunwoo Kim <gunwooterry@gmail.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Review: no blocking issue at head I checked every index into
Non-blocking
|
TL;DR
Background
Encoder tile copies retain more row padding than prediction needs. This adds initialization and copying work to every macroblock.
What changes
Library output and public APIs stay unchanged.
After merging: None.
Decisions
Evidence
Verification run: Automatic and forced-scalar release builds each pass all 91 library tests and Clippy with warnings denied. Across ten corpus cells and 286 generated fixture cells, all 4,736 verification encodes preserve complete streams and reconstructions at 1, 2, 3 and 8 requested workers. The pinned FFmpeg 9.0.2 oracle matches all 296 reconstructions.
cargo fmt --all --checkpasses.Exact-head similarity at
8d2d7daaf139c0e2ebe10bc4b67b9c1d2927489b: 110 spans, 0 not allowlisted, 0 problems. One existing HEVC allowlist entry is reported stale; this change touches no HEVC code.Links: Refs #26.
git commit -s, DCO).Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit