Repository navigation
perf(hevc): shortcut no-refill CABAC decisions - #521
Closed
gunwooterry wants to merge 3 commits into
Closed
gunwooterry wants to merge 3 commits into
gunwooterry wants to merge 3 commits into
Conversation
Signed-off-by: Gunwoo Kim <gunwooterry@gmail.com>
Signed-off-by: Gunwoo Kim <gunwooterry@gmail.com>
Signed-off-by: Gunwoo Kim <gunwooterry@gmail.com>
|
Caution Review failedThe pull request is closed. Walkthrough
|
|
Closing because the measured benefit does not justify a permanent assembly site and its maintenance burden. |
13 of 41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Background
Common most-probable-symbol decisions can finish without consuming another bit, but still pass through the general arithmetic and normalization path. Refs #22.
What changes
Decoded pictures, accepted syntax, errors and caller budgets remain unchanged. Default builds and non-x86-64 decoding are unchanged.
After merging: None.
Decisions
test-supportfeature.Evidence
Verification run: At
d362536f3a0ba3a3fd70511878d6a37af3efafd2, formatting, targeted Clippy, the CABAC fuzz-target build and the unsafe-site inventory passed after integrating the newest kernels. The x86 tests cover all 12,501,120 legal range, offset and context combinations, partial refills, invalid contexts and terminal behavior; 258 automatic and 256 scalar tests passed, as did 9,830,892 explicitly fast-versus-safe differential fuzz cases. Decoder-only alternating comparisons against the integrated baseline verified complete pixel and work identity. Complete exact-head conformance/census remains pending. Similarity reported one generic Rust operand/option declaration span, outside the arithmetic templates; a pinned exception and refreshed guard remain pending. No comparison implementation source was read.Links: entropy design, unsafe-site inventory.
git commit -s, DCO).Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit