fix(spanlogger): set span error tag when log level is error - #7834
Open
Goutham-Annem wants to merge 1 commit into
Open
fix(spanlogger): set span error tag when log level is error#7834Goutham-Annem wants to merge 1 commit into
Goutham-Annem wants to merge 1 commit into
Conversation
When SpanLogger.Log() is called with level=error in the key-value pairs, the associated span's error tag was not being set, so errors logged through SpanLogger were invisible as errors in tracing UIs. Scan the kvps in Log() for a level=error pair and call ext.Error.Set when found, consistent with the existing Error() method behaviour. Fixes cortexproject#3016 Signed-off-by: Goutham Annem <gouthemannem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When
SpanLogger.Log()is called withlevel=errorin the key-value pairs, the associated OpenTracing span's error tag is not set. This means errors logged throughSpanLoggerare invisible as errors in tracing UIs (Jaeger, Zipkin, etc.), even though they appear correctly in structured logs.The existing
SpanLogger.Error()method does setext.Error.Set(span, true)correctly.Log()should mirror that behaviour when it detects alevel=errorpair in its kvps.Checklist
git commit -s)Fixes #3016