[Bug]: Cannot draw multiple lines with empty point #6

Activity

1. stregouet

   assigned

   GiyoMoon

   on Jun 12, 2026
2. stregouet

   added

   bug (unverified)A bug yet to be verifiedA bug yet to be verified

   on Jun 12, 2026
3. p32929 commented on Sep 20, 2026

   

   p32929

   on Sep 20, 2026

   More actions

   @stregouet I dug into this — it is two separate bugs, and the second one is why the whole chart breaks instead of just the hole.

   1. lib/createSeries.ts builds the axis domain with Math.min/Math.max over the raw series:

   const min = Math.min(...data, ...stackValues)
   ...
   max = max ?? Math.max(...data)

   accessData() returns undefined for the entry where you delete data.value2, and Math.min(1, undefined) is NaN. So the axis registers {min: NaN, max: NaN}, createPoints.ts builds scaleLinear on a NaN domain, and every point it maps comes back NaN — including the points of your first line, which has no holes at all. That is why it looks like the library cannot do gaps.

   2. lib/utils.ts lets NaN through the gap check:

   const pointDefined = (point: [number, number]) =>
     typeof point[0] === 'number' && typeof point[1] === 'number'

   typeof NaN === 'number'. So the segment-splitting in shapes/Curve.tsx — which is already written correctly and already supports connectNulls — never sees the hole and hands NaN to d3's line().

   So the feature you are asking for already exists, it is just unreachable: <Line connectNulls /> (or the default segmented behaviour) is exactly what you want, and both paths are broken by the two lines above.

   I opened a PR with the fix: #8 — pointDefined uses Number.isFinite, and createSeries filters non-finite values before computing the domain. No API change.

   Unblocking yourself today (last commit on this repo is 2025-07-06, so I would not wait on a release). Patch the installed package — with pnpm:

   pnpm patch solid-charts
   

   then in the printed temp dir, in dist/index.js, change the two spots above, and pnpm patch-commit <dir>. With npm/yarn, patch-package does the same. Two lines and you are unstuck.

   ---

   _{Free either way — you owe me nothing for the above. If you'd rather just hand it off: I take fixed-scope jobs like this, $35 for a small fix, through Fiverr escrow so you only pay on delivery — fiverr.com/fayazbinsalam · full rates: p32929.github.io/hire}