Repository navigation
FIX: Reloading partial TAC calibration file clears previous parameters - #296
Merged
Merged
Conversation
ckierans
approved these changes
Nov 3, 2026
|
|
||
| m_TACCal.clear(); | ||
| m_DetectorIDs.clear(); | ||
|
|
Collaborator
There was a problem hiding this comment.
Isn't this clear redundant with the clear in initialize since you read LoadTACCalFile immediately after Initialize? It's fine to be redundant, I'm just wondering if there's a case where we need both clears.
Author
There was a problem hiding this comment.
It's probably redundant, I can revert the last commit.
Author
There was a problem hiding this comment.
Now, we only clear in LoadTACCalFile
(which is where these vectors are populated)
fhagemann
force-pushed
the
fix/tac-calibration
branch
from
November 3, 2026 19:09
c3943b5 to
3ab9bed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273.
Looks like the unit tests referenced in that issue were missing, so I added new unit tests (with
ExpectedToFail) and then the fix that made theExpectedToFailstatements obsolete.