Skip to content

Trigger modules issues fixes - #305

Draft
parshadkp wants to merge 5 commits into
cositools:develop/emfrom
parshadkp:triggers-bug-fixes
Draft

parshadkp wants to merge 5 commits into
cositools:develop/emfrom
parshadkp:triggers-bug-fixes

Conversation

@parshadkp

@parshadkp parshadkp commented Nov 16, 2026 •

Copy link
Copy Markdown

Fixing issue #280 and #282. Still working on it but will be ready by Tuesday ...

Since I haven't been able to attend the CDEE meeting, I am not sure what the most up to date mass model is to check my fixes. @ckierans is there one I should use for the full 16 GeDs and all ACS that has been tested to work with the DEE? Also, we need to eventually add in the small hockey puck detectors. Are these in any mass models already?

Regarding the 3rd issue in #282. I am not sure if we should veto sub-threshold GR hits or not (for e.g. veto from nearest neighbor onto GR)? Can someone comment on this? Maybe @fhagemann or @ckierans? This is also mentioned in PR #290.

Finally one more question, should single sided events contribute to dead time?

@parshadkp parshadkp added bug Something isn't working DEE Development related to the detector effects engine labels Nov 16, 2026
@parshadkp parshadkp changed the title Shield detector grouping fix Trigger modules issues fixes Nov 16, 2026
1. Coincident strip events were not actually increasing strip dead time because they were blocked by MModuleDEESMEX.
2. FastClearDeadtime could increase total strip dead time reported in c_info more than once for the same veto. Logic was still correct for the events.
3. Strip states survived reinitialization.

These issues should be fixed now.
@fhagemann

Copy link
Copy Markdown

Regarding the 3rd issue in #282. I am not sure if we should veto sub-threshold GR hits or not? Can someone comment on this? Maybe @fhagemann or @ckierans? This is also mentioned in PR #290.

My take on this is that sub-threshold GR hits should not trigger the GR veto (because they wouldn't be read out in the first place). As you pointed out, the current DEE keeps sub-threshold GR hits, but this should be addressed in #290:
3686175

So maybe we can wait with this PR until #290 is merged to address the sub-threshold GR question if there is still things to be done (?)

@fhagemann

Copy link
Copy Markdown

Finally one more question, should single sided events contribute to dead time?

I just asked Brent this: Yes, single-sided events contribute to that ASIC's dead time.

@ckierans

Copy link
Copy Markdown
Collaborator

Thanks, Parshad! Please use the payload mass model with 16 detectors to check things: https://github.com/cositools/massmodel-cosi-payload. Note that there are two branches: the unit-level-thicknesses branch works with DEE files found in the resource/COSISMEX/calibration directory that have derived-from-unitlevel" in their file name.

The D0/D1 hockey puck detectors are in this massmodel: https://github.com/cositools/massmodel-cosi-smex-detailed/tree/CDR-v36, and @vfioretti is currently trying to get it compatible with the DEE.

@fhagemann

Copy link
Copy Markdown

PR #290 was just merged, so let's see if your issue with the sub-threshold GR hits still persists or was tackled by that already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working DEE Development related to the detector effects engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants