Skip to content

feat(verifier): scope bot exemptions to approved repositories 馃敀 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glokos merged 2 commits into from
Sep 1, 2026
Merged

feat(verifier): scope bot exemptions to approved repositories 馃敀 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fb9269
feat(verifier): scope bot exemptions to approved repositories 馃敀
glokos Sep 1, 2026
ae683f0
chore: allow Renovate on all repos
glokos Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,8 @@ Verifies that pull request commits are SSH-signed with enrolled,
hardware-backed (`sk-`, FIDO2) keys. Runs on pull requests and in merge queues as
an organization required workflow; the enrollment registry is
[`allowed_signers`](allowed_signers).

Bot exemptions are per repository: `ALLOWED_BOTS` in
[`verify_commits.sh`](verify_commits.sh) maps `owner/repo` to the bot logins
allowed there, plus a `"*"` list that applies everywhere. A bot listed nowhere
gets no exemption.
29 changes: 25 additions & 4 deletions verify_commits.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env bash
# See README.md for what this checks, how it works, and its limits.
# Usage: GH_TOKEN=... GITHUB_REPOSITORY=owner/repo verify_commits.sh <pr-number|merge-queue-ref>
# Requires: gh, jq, ssh-keygen
set -euo pipefail

: "${GH_TOKEN:?GH_TOKEN required}"
Expand All @@ -26,24 +27,44 @@ WORKDIR="$(mktemp -d)"
trap 'rm -rf "$WORKDIR"' EXIT

WEBFLOW_EMAIL="noreply@github.com"
WEBFLOW_BOT_LOGINS=("renovate[bot]" "github-actions[bot]" "cow-github-bot[bot]")
ALLOWED_AUTOMATED_LOGINS=("cow-protocol")

# "*" applies to every repository, the rest add to it. A bot listed nowhere
# gets no exemption and fails like anyone else.
ALLOWED_BOTS='{
"*": ["renovate[bot]"],
"cowprotocol/infrastructure": ["cow-github-bot[bot]"],
"cowprotocol/services": ["cow-github-bot[bot]"]
}'

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
ALLOWED_SIGNERS_FILE="${ALLOWED_SIGNERS_FILE:-$SCRIPT_DIR/allowed_signers}"

log() { printf '[verify-commits] %s\n' "$*" >&2; }

if ! REPO_BOTS="$(jq -r --arg repo "$GITHUB_REPOSITORY" '(.["*"] // []) + (.[$repo] // []) | .[]' <<<"$ALLOWED_BOTS")"; then
echo "::error::ALLOWED_BOTS is not valid JSON"
exit 1
fi
if [[ -n "$REPO_BOTS" ]]; then
log "bots allowed on $GITHUB_REPOSITORY: ${REPO_BOTS//$'\n'/ }"
else
log "no bots allowed on $GITHUB_REPOSITORY"
fi

is_allowed_bot() {
[[ -n "$1" && -n "$REPO_BOTS" ]] && grep -qxF "$1" <<<"$REPO_BOTS"
}

is_allowed_automated_account() {
local author_login="$1" author_email="$2" signature_file="$3" payload_file="$4"
printf '%s\n' "${ALLOWED_AUTOMATED_LOGINS[@]}" | grep -qxF "$author_login" || return 1
is_allowed_bot "$author_login" || return 1
in_allowed_signers_registry "$author_email" "$signature_file" "$payload_file"
}

is_verified_webflow() {
local author_login="$1" committer_email="$2" verified="$3"
[[ "$committer_email" == "$WEBFLOW_EMAIL" && "$verified" == "true" ]] || return 1
printf '%s\n' "${WEBFLOW_BOT_LOGINS[@]}" | grep -qxF "$author_login"
is_allowed_bot "$author_login"
}

fingerprint_of_key() {
Expand Down