Repository navigation
feat(buy-sol) PR 5: document where a native SOL sell order's solver fee stays - #4993
Closed
squadgazzz wants to merge 1 commit into
Closed
squadgazzz wants to merge 1 commit into
squadgazzz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #4986.
The solver fee docs say a sell order's fee stays in the buy-mint buffer PDA. That's not where it goes for a sell order that buys native SOL. #4986 unwraps the whole swap output to the solver and moves only the payouts into the state PDA, so the fee margin stays in the solver's lamports. #4986 explains the choice: a fee left in the state PDA would be stuck there until SC-403.
Changes
How to test
Doc change only.