enforce settlement deadline check via smart contract - #5008
Draft
MartinquaXD wants to merge 4 commits into
Draft
MartinquaXD wants to merge 4 commits into
MartinquaXD wants to merge 4 commits into
Conversation
Encoding a validated settlement without a deadline shouldn't fail, so there's no reason to catch and swallow the error. Introduce a local SimulateError that wraps both simulator and encoding failures and let callers filter for reverts as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The reference driver already tries to cancel settlement transactions in time but does not always succeed. This can actually cause damages to an honest solver that tries to settle the same order in the next auction but fails because the uncancelled tx settled the order after the deadline.
Changes
DeadlineCheckcontractDeadlineCheckcontract. The deadline check will throw an error if the block's block number is greater than the configured deadline. And because the call happens via an untrampolined interaction the revert will not be caught and actually revert the whole settlement.How to test
added a driver test that checks that the tx submitted by the driver will revert if it gets replayed after the deadline