feat: add directoryIds/branchIds to Apply Pre-Translation - #405
Merged
andrii-bodnar merged 1 commit intoSep 14, 2026
Merged
andrii-bodnar merged 1 commit into
andrii-bodnar merged 1 commit into
Conversation
Apply Pre-Translation now accepts directoryIds and branchIds to pre-translate whole directories and branches in file-based projects, and the pre-translation status attributes reflect them back. Also renamed the preTranslationId parameter to jobIdentifier on preTranslationStatus, editPreTranslation, and getPreTranslationReport to match the API's renamed path parameter (not a wire change). Fixes crowdin#402
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply Pre-Translationnow accepts optionaldirectoryIds/branchIdsto pre-translate whole directories and branches in file-based projects, andPreTranslationStatus.Attributesreflects them back on the response.fileIdsremains present but is no longer the only way to scope a pre-translation job.Also renamed the
preTranslationIdparameter tojobIdentifieronpreTranslationStatus,editPreTranslation, andgetPreTranslationReport, matching the API's renamed path parameter. This is a parameter-name-only change (same types/positions), so it doesn't affect compiled callers.Added a
TestClientmock test with request/response fixtures coveringdirectoryIds/branchIds, verified to fail to compile without the model change and pass with it.Fixes #402