Repository navigation
feat: lock the browser after 1 hour of inactivity - #63
Merged
Merged
Conversation
Add "After 1 hour of inactivity" as a lock setting and make it the default for users with no saved choice. Activity in any tab keeps every tab unlocked. The first input after a long absence locks, because timers stop while a device sleeps. An idle locked tab stops reconnecting its device-flow stream until someone returns, and the unlock dialog says why the browser locked. Also raise the mobile header above the page content, so the user menu is no longer hidden under the editor on phones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
lockBrowserOn, through the Mongoose default and serializer fallback. Users with a saved choice keep it. There is no migration.localStorage.relative z-20, as the desktop header does.The server-side session does not change. No crypto flow changes. The lock wipes local keys through the existing
keystore.wipeAll.Behavior to know
Verification
apps/web:pnpm lint,pnpm check,pnpm buildpass.pnpm test:browser-lock: 16 passed.backend:pnpm test(205 passed),pnpm buildpass.pnpm generate:backend-sdkoutput is committed.The existing test "an open tab stays unlocked across reloads and idle time" is flaky. It failed on clean
mainand passed in the final full run on this branch. This PR does not change it.Visual review
Screenshots of the running app (user menu and idle lock dialog, 1280px and 390px) went through an independent UI review. The app has only a dark theme.
ghcannot upload images, so they are not attached here.Fixed: the clipped phone menu, the missing lock reason, and early text wrap in the dialog.
Not addressed, because these parts existed before this work: "Log out" placement in the dialog, the visual weight of the device card, dialog copy, touch target size, backdrop blur strength, and the "Saved" control overlapping tabs on phones.
🤖 Generated with Claude Code