Repository navigation
docs: make the architecture page and ADR-0005 match the real package graph - #96
Merged
csdev19 merged 2 commits intoOct 25, 2026
Conversation
…nifests Refs NIW2-340 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The page said generate depends on no workspace package and that nothing reaches sideways. generate depends on core and schema, editor depends on generate, schema, tokens and core, and mcp depends on generate. The page now carries the edge list the new test checks, and ADR-0005 notes that core is Node-bound today and that apps/relay does not exist yet. Refs NIW2-340 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The architecture page's package graph had drifted from the code. It said
generate"depends on no workspace package at all" and that "nothing below [the CLI] reaches sideways". The manifests say otherwise:generatedepends oncoreandschema,editoroncore,generate,schemaandtokens, andmcpongenerate. ADR-0005 also assumedcoreruns on the edge, whilecoreimportsnode:fs,node:pathandnode:cryptoin eight modules (onlyserveris free ofnode:imports).scripts/docs/architecture-graph.test.ts, committed before the doc fix): derives every@laqi/*edge from all workspacepackage.jsonfiles and compares it with the edge list in the<!-- graph:edges -->block on the architecture page, in both directions. It also checks the graph has no cycle, since the page promises that.core. When NIW2-335 changes theeditor -> coreedge, that is a one-line edit to the block.coreis Node-bound today,apps/relaydoes not exist (ADR-0007 defers it) and the relay needs a storage port incorefirst. The decision itself is not rewritten.No package code changed.
Two details differ from the ticket text:
corehas 8node:modules, not 5, andapps/site -> tokensandexamples/todo-app -> apps/cliare real edges, so they are in the list too.Verification
bun run verifyrun twice in a row: both passed (119 files, 1628 tests). The local worktree has an untracked, git-excluded Gas City file (.claude/skills/.gc-skill-ownership.json) thatoxfmt --checkflags, so I moved it aside for these runs and restored it; CI never sees it.How to test it yourself
bun run test scripts/docs/architecture-graph.test.tspasses.packages/mcp/package.json, remove@laqi/generatefromdependenciesand rerun it: it fails and namesmcp -> generateas the missing edge. Restore the file.apps/documentation/src/content/docs/architecture/index.md) and the note at the top of ADR-0005 (apps/documentation/src/content/docs/decisions/0005-monorepo.md).Refs NIW2-340
Run: Gas City session ni-wisp-usvasbi, bead la-79o, Mac mini
🤖 Generated with Claude Code