Repository navigation
Issue #71 - add a sample project with tests - #374
Merged
Merged
Conversation
I realised that it's stupid writing a sample TODO app when loads of FOSS examples exist already! I'm going to switch to TodoMVC instead of writing my own. This is the last commit before I remove this project and import TodoMVC.
If the actor can't save the screenshot then we're going to end up throwing after all, even if we didn't want to. Via the `PerformableFailureScreenshotTaker` this puts us into an endless loop which ends in a stack overflow.
The WebDriver Extensions project needed upgrading and some changes were needed to the service provider adapter also. This is all to work around limitations in the BoDi DI container.
This has the basis of some tests for the TodoMVC web app. Right now only one, which proves the app opens, but it can be expanded upon now that the overall mechanism is working.
I dunno why the last build run failed, but if it's a directory not found issue, then this will make it noisy.
This might even fix it!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will resolve #71 once it's closed. It adds a sample test project to CSF.Screenplay which combined Reqnroll, Selenium and Screenplay to test the TodoMVC web app. TodoMVC was picked because it's a simple, working, already-tested web app that is perfect for writing automated tests. It also features no server component, so it can be 'spun up' with just Node.