(Stacked PR) Psypact pipelines + initial common-python directory - #1937
Open
dylanmrowe wants to merge 24 commits into
Open
dylanmrowe wants to merge 24 commits into
dylanmrowe wants to merge 24 commits into
Conversation
The local backup vaults were locked at a 180-day minimum retention, but the prod frequent_updates policy retains for 120 days. AWS Backup rejects the backup job before it ever reaches the cross-account copy, failing hourly on the data event table with "Backup job failed because the lifecycle is outside the valid range for backup vault." 180 was inherited when this app was copied from compact-connect. cosmetology-app and the shared common-cdk stack that social-work-app uses both set 90, which also matches the cross-account vaults in multi-account/backups. Align psypact with those. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
psypact-app's backend hosted zone (psypact.compactconnect.org) differs from the shared frontend UI domain (app.compactconnect.org). The ui_domain_name_override context field already exists in the shared Stack.ui_domain_name property (common-cdk/common_constructs/stack.py), but psypact-app was missing the surrounding support that cosmetology-app and social-work-app already have for it: - Added the field to all four context examples (test/beta/prod/sandbox) - Documented it in the README, following the cosmetology-app section - Updated test_sandbox.py's no-domain test cases to also drop the override, matching the del-block pattern used in the other two apps No production code changes; the field was already functional via the shared stack.py, this just brings psypact-app's example config, docs, and tests in line with the established pattern. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
PSYPACT is moving to its own dedicated domain, psypactportal.org, registered at GoDaddy, rather than a subdomain of compactconnect.org. Add a concrete walkthrough to the README's Route53 section covering: - Creating the production hosted zone for psypactportal.org in the CSG production AWS account - Delegating the domain from GoDaddy to that zone (nameserver change, not a DNS record addition, plus a DNSSEC callout) - Creating and NS-delegating the beta.psypactportal.org and test.psypactportal.org subdomain zones, following the existing production-to-test delegation pattern already documented above - The per-zone base-domain A record already called out in the existing warning - Updating each environment's domain_name (and ui_domain_name_override, if the UI needs to resolve somewhere other than the default app.<domain_name>) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
eventually this will be extracted to a versioned package, but for now we're just implementing logical separation of common lambda handlers and schemas.
Contributor
|
Important Review skippedToo many files! This PR contains 718 files, which is 618 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (22)
📒 Files selected for processing (718)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dylanmrowe
force-pushed
the
dylan/psypact-pipelines
branch
from
September 23, 2026 16:34
39f2a6c to
d5bcba3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements List
Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsbackend/compact-connect/tests/unit/test_api.pyrun compact-connect/bin/download_oas30.pyCloses #