Frontend/psypact scaffold - #1938
Open
jsandoval81 wants to merge 8 commits into
Open
jsandoval81 wants to merge 8 commits into
jsandoval81 wants to merge 8 commits into
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 120 files, which is 20 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (120)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@coderabbitai Can you review just the files in |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh api --paginate repos/csg-org/CompactConnect/pulls/1938/files --jq '.[].filename' | awk 'BEGIN{all=0; webroot=0} {all++; if ($0 ~ /^webroot\//) {webroot++; print}} END {printf "TOTAL_CHANGED=%d\nWEBROOT_CHANGED=%d\n",all,webroot > "/dev/stderr"}'Length of output: 5067 🤖 web_search executed:
Length of output: 13421 🤖 web_search executed:
Length of output: 13567 🏁 Script executed: #!/bin/bash
set -euo pipefail
fd -HI -t f '(^|/)(\.coderabbit\.(yaml|yml)|coderabbit\.(yaml|yml))$' . | while IFS= read -r file; do printf '\n--- %s ---\n' "$file"; rg -n -C5 'path_filters|reviews:|webroot|base:' "$file" || true; doneLength of output: 375 🏁 Script executed: #!/bin/bash
set -euo pipefail
base=$(gh api repos/csg-org/CompactConnect/pulls/1938 --jq '.base.sha')
printf 'BASE=%s\n' "$base"
git diff --stat "$base"...HEAD -- webroot | tail -n 102
printf '\nCHANGED LINES\n'
git diff --numstat "$base"...HEAD -- webroot | sort -nr | head -n 55Length of output: 9264 🏁 Script executed: #!/bin/bash
set -euo pipefail
base=9f4d2dfd9bd61805bf1434a167cd7acb298a3f85
git diff "$base"...HEAD -- webroot/src/app.config.ts webroot/src/components/App/App.ts webroot/src/components/AppTypeSelector/AppTypeSelector.ts webroot/src/network/apiUrls.ts webroot/src/plugins/Compacts/compacts.plugin.ts webroot/src/plugins/EnvConfig/envConfig.plugin.ts webroot/src/router/index.ts webroot/src/router/routes.ts webroot/src/store/global/global.actions.ts webroot/src/store/global/global.getters.ts webroot/src/store/global/global.mutations.ts webroot/src/store/global/global.state.ts webroot/src/store/user/user.actions.ts webroot/src/store/user/user.mutations.ts webroot/src/store/user/user.state.ts webroot/src/utils/auth.ts webroot/src/utils/compactConfig.ts webroot/src/pages/AuthCallback/_mixins/handler.mixin.ts webroot/src/pages/Logout/Logout.ts webroot/src/pages/Home/Home.tsLength of output: 41501 🏁 Script executed: #!/bin/bash
set -euo pipefail
ast-grep outline webroot/src/router/index.ts --items all
ast-grep outline webroot/src/components/App/App.ts --items all --match 'created|handleAuth|ensureCompactStates|setAppModeFromCompact'
ast-grep outline webroot/src/utils/auth.ts --items all --match 'getCognitoConfig|getHostedLoginUri|getAuthCallbackPath'
sed -n '25,158p' webroot/src/router/index.ts
sed -n '125,251p' webroot/src/components/App/App.ts
sed -n '132,218p' webroot/src/utils/auth.ts
rg -n -C3 'getHostedLoginUri\s*\(|getCognitoConfig\s*\(' webroot/src --glob '!*.spec.ts'Length of output: 18090 🏁 Script executed: #!/bin/bash
set -euo pipefail
base=9f4d2dfd9bd61805bf1434a167cd7acb298a3f85
git diff "$base"...HEAD -- webroot/src/pages/PublicDashboard/PublicDashboard.ts webroot/src/pages/PublicDashboard/PublicDashboard.vue webroot/src/components/AppTypeSelector/AppTypeSelector.vue webroot/src/components/Page/PageMainNav/PageMainNav.vue webroot/src/components/Page/PageHeader/PageHeader.vue webroot/src/pages/PrivacyPolicy/PrivacyPolicy.ts webroot/src/pages/PrivacyPolicy/PrivacyPolicy.vue webroot/src/components/LicenseCard/LicenseCard.ts webroot/src/components/PrivilegeCard/PrivilegeCard.ts | head -n 630
printf '\nDASHBOARD REFERENCES\n'
rg -n -C3 'licenseeLoginUri\s*\(|staffLoginUri\s*\(|isAppModeCosmetology|isAppModeSocialWork|isAppModePsyPact' webroot/src/pages/PublicDashboard webroot/src/pages/MfaResetStartLicensee webroot/src/components/Page/PageMainNavLength of output: 25820 🏁 Script executed: #!/bin/bash
set -euo pipefail
base=9f4d2dfd9bd61805bf1434a167cd7acb298a3f85
git diff "$base"...HEAD -- webroot/src/pages/PublicDashboard/PublicDashboard.ts webroot/src/pages/PublicDashboard/PublicDashboard.vue webroot/src/pages/PrivacyPolicy/PrivacyPolicy.ts webroot/src/pages/PrivacyPolicy/PrivacyPolicy.vue
printf '\nDASHBOARD REFERENCES\n'
rg -n -C3 'licenseeLoginUri\s*\(|staffLoginUri\s*\(|isAppModeCosmetology|isAppModeSocialWork|isAppModePsyPact' webroot/src/pages/PublicDashboard webroot/src/pages/MfaResetStartLicensee webroot/src/components/Page/PageMainNav || trueLength of output: 35082 🏁 Script executed: #!/bin/bash
set -euo pipefail
ast-grep outline webroot/src/components/LicenseActionsModal/LicenseActionsModal.ts --items all --type method --view compact
rg -n -C4 'licenseScope|isCurrentUser.*Admin|shouldAllowNpdbMultiSelect|currentCompactType|submit.*\(' webroot/src/components/LicenseActionsModal/LicenseActionsModal.ts | sed -n '1,260p'
git diff 9f4d2dfd9bd61805bf1434a167cd7acb298a3f85...HEAD -- webroot/src/components/LicenseCard/LicenseCard.vue webroot/src/components/PrivilegeCard/PrivilegeCard.vue | tail -n 140Length of output: 981 🏁 Script executed: #!/bin/bash
set -euo pipefail
ast-grep outline webroot/src/components/LicenseActionsModal/LicenseActionsModal.ts --items all --type method --view signatures
rg -n -C3 'licenseScope|isCurrentUser.*Admin|shouldAllowNpdbMultiSelect|currentCompactType|submit.*\(' webroot/src/components/LicenseActionsModal/LicenseActionsModal.ts | sed -n '1,230p'
git diff 9f4d2dfd9bd61805bf1434a167cd7acb298a3f85...HEAD -- webroot/src/components/LicenseCard/LicenseCard.vue webroot/src/components/PrivilegeCard/PrivilegeCard.vue | tail -n 110Length of output: 14326 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf 'OLD LICENSE CARD MENU\n'
git show 9f4d2dfd9bd61805bf1434a167cd7acb298a3f85:webroot/src/components/LicenseCard/LicenseCard.vue | rg -n -C6 'isCurrentUserLicenseAdmin|isCurrentUserLicenseStateAdmin|isLicenseActionMenuDisplayed|toggleLicenseActionMenu' | sed -n '1,115p'
printf 'NEW MODAL MENU\n'
sed -n '145,192p' webroot/src/components/LicenseActionsModal/LicenseActionsModal.ts
rg -n -C5 'shouldShowMenu|shouldShowDeactivateMenuItem|shouldShowDisciplineMenuItems|LicenseActionsModal' webroot/src/components/LicenseActionsModal/LicenseActionsModal.vue webroot/src/components/LicenseCard/LicenseCard.vue
printf 'LOGIN LINES\n'
nl -ba webroot/src/utils/auth.ts | sed -n '172,195p'
nl -ba webroot/src/pages/PublicDashboard/PublicDashboard.vue | sed -n '99,111p'Length of output: 17425
Provider login fails in cosmetology and social work modes. I did not find a permission change in the shared license action menu: its state-admin condition matches the previous You are interacting with an AI system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements List
.envnew variables:Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #1860