refactor(cursor-team-kit): rewrite thermo-nuclear review skill for frontier models - #311
Open
OmerFarukOruc wants to merge 1 commit into
Open
refactor(cursor-team-kit): rewrite thermo-nuclear review skill for frontier models#311OmerFarukOruc wants to merge 1 commit into
OmerFarukOruc wants to merge 1 commit into
Conversation
…ontier models Same name, frontmatter, 1000-line rule, and seven concerns. The body becomes six steps with completion criteria, seven positive checks with reasons, a severity table, a fixed report template, four example findings, and an explicit read-only scope. Measured on Claude Fable 5.1 at medium effort against the current text: same recall within one contested item, verdict-first in 9 of 9 reports, twice the file:line anchors, fewer cosmetic extras, 6 of 9 blind pairwise wins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites the body of
thermo-nuclear-code-quality-review/SKILL.mdfor current frontier models. The frontmatter, the name, the 1000-line rule, and the seven review concerns are unchanged. The text around them changes shape.Why
The current text was written for models that needed pushing. It says "be ambitious", "push hard", "do not be satisfied" many times. Current models already give that effort. What they still need is control over the output: a fixed report shape, exact code locations, a clear end condition, and a scope line that keeps a review from turning into edits.
The Anthropic guide for prompting Claude Fable 5.1 names four patterns that the current text works against. The same patterns apply to other frontier models.
Before and after
<examples>tags, including an approve verdictEvidence
I ran both texts as the system prompt for the same review task on Claude Fable 5.1 at
mediumeffort. Three cases, three repeats each, 9 runs per text: a synthetic TypeScript branch with 11 planted smells and one clean decoy, and two real Kotlin pull requests with answer keys from an earlier independent review. A separate model graded each report against the key, and a blind judge compared each pair with labels shuffled.file:lineanchors per reportBoth texts find almost the same problems. The 3 point gap is one contested item on one pull request, where the rewrite read a two-value enum as two real predicates and said so. The gain is in the report: a fixed shape, twice the exact locations, less noise, and a lower cost. The sample is small. Read the numbers as a direction.
Compatibility
agents/thermo-nuclear-code-quality-review.mdloads this file as its rubric and asks for output "in the priority order the rubric specifies". The template keeps that order: blockers, then majors, then minors. The agent description still says "code-judo"; I left it alone to keep this change to one file.The harness (fixture generator, answer keys, grader, aggregator, all 27 transcripts) is in a private repo. Ask in this thread and I will attach it or open it as a separate PR.
Note
Low Risk
Documentation-only change to an agent skill rubric; no application code, auth, or data paths affected.
Overview
Rewrites the body of
thermo-nuclear-code-quality-review/SKILL.mdso maintainability reviews produce consistent, actionable reports. Frontmatter, the seven concerns, and the 1000-line rule stay the same; the surrounding instructions are restructured.The old rubric-heavy prose (repeated “do not” rules, “code judo” phrasing, approval bars scattered across sections) is replaced with six ordered steps (fix diff range, read full files, judge hunks, name complexity-deleting restructures, write report, finish in one turn), each with an explicit done when condition. Reviews are read-only by design—findings go in the report, not edits.
Seven checks are stated once as positive targets (delete vs rearrange complexity, file size, shared-flow special cases, direct vs magic code, typed boundaries, canonical layer/helpers, parallel/atomic orchestration), plus a blocker / major / minor table and a fixed report template (verdict first,
file:linequotes, restructuring section, evidence). Nine one-line “good phrases” become four full example findings in<examples>tags.Reviewed by Cursor Bugbot for commit db45ad4. Bugbot is set up for automated code reviews on this repo. Configure here.