Skip to content

fix(advisor): address hook scripts via CURSOR_PLUGIN_ROOT - #315

Merged
cursor[bot] merged 2 commits into
mainfrom
cursor/advisor-hook-paths-d0dd
Sep 4, 2026
Merged

fix(advisor): address hook scripts via CURSOR_PLUGIN_ROOT#315
cursor[bot] merged 2 commits into
mainfrom
cursor/advisor-hook-paths-d0dd

Conversation

@ericzakariasson

Copy link
Copy Markdown
Member

Summary

Follow-up to #314 before the marketplace re-indexes main.

  • Hook paths. hooks.json referenced its scripts as ./hooks/*.sh, the same layout ralph-loop uses, which the plugin registry classifies as public-invalid. Plugin hooks do not run from the plugin directory, so those commands fail with exit 127 from any other cwd. Switched to bash "${CURSOR_PLUGIN_ROOT}/hooks/*.sh", the form continual-learning uses, which indexes and runs cleanly. Verified by running the exact command strings from /tmp with CURSOR_PLUGIN_ROOT set: all four hooks exit 0 and update state as expected.
  • Docs. One line of the skill's briefing checklist missed the previous commit: transcript_path is only forwarded when advisor mode is on in this conversation, matching the consult rules landed in feat(advisor): add Advisor plugin (Grok 4.6 consults at key checkpoints) #314.

Verification

  • node scripts/validate-plugins.mjs passes.
  • Hook scripts unchanged; the 28-scenario simulated payload suite still passes, plus the cwd-independence check above.
Open in Web Open in Cursor 

cursoragent and others added 2 commits September 4, 2026 12:36
Plugin hooks do not run from the plugin directory, so ./hooks/... paths
fail with exit 127 (the same layout ralph-loop uses, which the registry
classifies as invalid). Use bash "${CURSOR_PLUGIN_ROOT}/hooks/..." like
continual-learning, which indexes and runs cleanly.

Co-authored-by: Eric Zakariasson <ericzakariasson@users.noreply.github.com>
Completes the one-off-consult fix: the briefing checklist now matches the
consult rules and only forwards transcript_path when advisor mode is on
in this conversation.

Co-authored-by: Eric Zakariasson <ericzakariasson@users.noreply.github.com>
@cursor
cursor Bot merged commit 93b00b8 into main Sep 4, 2026
1 check passed
github-actions Bot added a commit to SmailG/claude-cursor-plugins that referenced this pull request Sep 5, 2026
…via CURSOR_PLUGIN_ROOT (cursor#315)

chore: sync with cursor/plugins — fix(advisor): address hook scripts via CURSOR_PLUGIN_ROOT (cursor#315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants