fix(advisor): address hook scripts via CURSOR_PLUGIN_ROOT - #315
Merged
Conversation
Plugin hooks do not run from the plugin directory, so ./hooks/... paths
fail with exit 127 (the same layout ralph-loop uses, which the registry
classifies as invalid). Use bash "${CURSOR_PLUGIN_ROOT}/hooks/..." like
continual-learning, which indexes and runs cleanly.
Co-authored-by: Eric Zakariasson <ericzakariasson@users.noreply.github.com>
Completes the one-off-consult fix: the briefing checklist now matches the consult rules and only forwards transcript_path when advisor mode is on in this conversation. Co-authored-by: Eric Zakariasson <ericzakariasson@users.noreply.github.com>
github-actions Bot
added a commit
to SmailG/claude-cursor-plugins
that referenced
this pull request
Sep 5, 2026
…via CURSOR_PLUGIN_ROOT (cursor#315) chore: sync with cursor/plugins — fix(advisor): address hook scripts via CURSOR_PLUGIN_ROOT (cursor#315)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #314 before the marketplace re-indexes
main.hooks.jsonreferenced its scripts as./hooks/*.sh, the same layoutralph-loopuses, which the plugin registry classifies aspublic-invalid. Plugin hooks do not run from the plugin directory, so those commands fail with exit 127 from any other cwd. Switched tobash "${CURSOR_PLUGIN_ROOT}/hooks/*.sh", the formcontinual-learninguses, which indexes and runs cleanly. Verified by running the exact command strings from/tmpwithCURSOR_PLUGIN_ROOTset: all four hooks exit 0 and update state as expected.transcript_pathis only forwarded when advisor mode is on in this conversation, matching the consult rules landed in feat(advisor): add Advisor plugin (Grok 4.6 consults at key checkpoints) #314.Verification
node scripts/validate-plugins.mjspasses.