Skip to content

Do not append to the caller's list in AbstractOctaveRepeatingScale (AI Assisted) #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscuthbert merged 2 commits into from
Sep 29, 2026
Merged

Do not append to the caller's list in AbstractOctaveRepeatingScale (AI Assisted) #2038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6321d5f
Do not append to the caller's list in AbstractOctaveRepeatingScale
float3 Sep 20, 2026
56abf23
Merge branch 'master' into octave-repeating-scale-keeps-callers-list
mscuthbert Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion music21/scale/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,7 @@ def buildNetwork(self, mode: t.Any = None) -> None:
intervalSum = interval.add(mode)
iComplement = intervalSum.complement
if iComplement is not None:
mode.append(iComplement)
mode = [*mode, iComplement] # a copy: mode is the caller's list

# steps wider than an octave complete a pattern spanning several
# octaves, which does not repeat every octave
Expand Down
9 changes: 9 additions & 0 deletions music21/scale/test_scale_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,15 @@ def testBasic(self):
<music21.pitch.Pitch F#5>],
'notMatched': [<music21.pitch.Pitch C#5>, <music21.pitch.Pitch G#5>]}''', pformat(sc1.match(sc2)))

def testOctaveRepeatingScaleLeavesModeAlone(self):
mode = ['M3', 'M3']
sc = scale.OctaveRepeatingScale('c4', mode)
self.assertEqual(mode, ['M3', 'M3'])
self.assertEqual(self.pitchOut(sc.pitches), '[C4, E4, G#4, C5]')

again = scale.OctaveRepeatingScale('c4', mode)
self.assertEqual(self.pitchOut(again.pitches), '[C4, E4, G#4, C5]')

def testOctaveRepeatingScaleWiderThanAnOctave(self):
sc = scale.OctaveRepeatingScale('c4', ['P5', 'P5'])
self.assertEqual(self.pitchOut(sc.pitches), '[C4, G4, D5, C6]')
Expand Down
Loading