Repository navigation
Derive the stable tag check from the pinned SQLCIPHER_TAG - #3
Merged
Merged
Conversation
The tag check hardcoded the upstream version, so every SQLCipher bump silently invalidated stable releases until the workflow was edited too. It now reads the pinned tag from scripts/build-sqlcipher-xcframework.sh. RELEASE_TAG is set at job level so the failure cleanup step can run when validation fails before exporting it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stable release workflow rejected
sqlcipher-xcframework-v4.19.0-cypherair.1because its tag check hardcodedv4.17.0. The check now derives the expected tag fromSQLCIPHER_TAGinscripts/build-sqlcipher-xcframework.sh, so a SQLCipher bump needs no workflow edit.RELEASE_TAGis defined at job level so the failure-cleanup step no longer hits an unbound variable when validation fails early.Verified locally: the derived pattern accepts
...-v4.19.0-cypherair.<n>and rejects the old version and malformed tags.Authored with AI assistance (Claude Fable 5.1).