Repository navigation
fix(holdings): require the exact weight header before publishing spdr holdings - #85
Merged
Merged
Conversation
… holdings The UI reads holdings cells by the exact header text Name and Weight. The shared guard accepts Weight (%) for other brands, and a shifted workbook whose header row is not found parsed to 0 rows, which a new fund published as status empty. A 200 workbook now must carry the Name and Weight header row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (open-items etfs Q11, SPDR part)
New
spdrHoldingsProblemwraps the sharedholdingsGuard(block untouched): a holdings workbook that answered 200 must carry the exactNameandWeightheader row, otherwise the fund fails and keeps its published stateWeight (%)rename is rejected (the shared guard accepts it for other brands, but this UI reads onlycells.Weight)status: emptyholdings) now fails insteadstatus: emptyWhy
Owner decision 2026-10-25 (Q11): fix both SPDR findings
Checks
bun test: 38 pass, 0 fail, exit 0; same with the workflow's control defaults exported. The extended pipeline test (published fund withWeight (%), new fund with a shifted header-only sheet) fails on the old updaterbun build --target=bun scripts/update-data.ts --outfile=/dev/nullandsrc/main.tsx: ok.claude/tools/etfs/tc/check.sh: 48 errors before and after, none added;git diff --check: cleanNameandWeight(GLD, GLDM: no sheet)TICKERS=SPY,XLK,GLD,GLDM,SPAB,XLUI REQUEST_SLEEP=0 bun scripts/update-data.ts: 6 unchanged, 0 failed, no data diff