Repository navigation
fix(updater): one log tag width for the whole run - #94
Merged
Merged
Conversation
Every console tag is [ + 8 characters + ] with a space on each side, the fund progress tag included, so the columns line up through a whole run (the progress tag was 10 wide next to the 12-wide [ done ] lines, request labels like [edgar ] were 9 to 11 wide).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every console line tag of
scripts/update-data.tsnow has one width for the whole run:[+ 8 characters +], 12 in all, with at least one space on each side. That covers the fund progress tag of the shared output block ([ 48/48 ]was 10 wide next to[ done ]at 12), request labels that start retry and fallback lines ([edgar ],[ catalog ],[nport]) and padded tags (padEnd(9)}]without a closing space).Why
The columns of a run did not line up, e.g.
[ 48/48 ] JUST updatedabove[ done ] 48 funds: ....Checks
check-log-tags.ts(workspace etf-std tool): no non-canonical tag leftbun testTICKERS=<2 funds> bun ./scripts/update-data.tsrun, every tagged line checked for width 12