feat(briefing): review share and copy-link placements on the briefing surfaces - #6563
Draft
tomeredlich wants to merge 7 commits into
Draft
feat(briefing): review share and copy-link placements on the briefing surfaces#6563tomeredlich wants to merge 7 commits into
tomeredlich wants to merge 7 commits into
Conversation
The briefing variations only existed as a Storybook surfaces page, which can't show the controls behaving: the Snapshot buttons there are drawings of buttons. /dev/snapshot-briefing rebuilds the same three arguments — the /briefing list, the breakpoint gap in BriefPostHeaderActions, and the two places snapshot could go on the briefing itself — with the production SnapshotButton wired to a real ListSnapshotCard, so every capture puts the actual 1080x1080 PNG on the clipboard. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Snapshot came off the table for this surface, and the premise behind it
does not survive a read of the code: a brief is a normal post at
/posts/{slug}, so a link resolves for whoever receives it, and
useSharePost.copyLink already shortens it and tags it with
ReferralCampaignKey.SharePost.
What is left is which control, at which widths. The page now argues for
one-tap copy link everywhere, the share arrow only on the briefing
itself, and one glyph per row on the /briefing list — and records the
two real gaps: the hidden laptop:block wrapper in
BriefPostHeaderActions and BriefPostContent being its only caller.
Renamed to /dev/briefing-share and dropped ListSnapshotCard with it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The review page argued for these; this puts them where they belong so they can be judged on the actual /briefing list and briefing post rather than in a mock. - BriefPostHeaderActions: the cluster stops being `hidden laptop:block`, so the copy button that already existed is reachable on tablet and mobile, and a share arrow joins it for the native sheet. - BriefListItem: a copy button per row, rendered after the CardLink with `relative z-1` so the overlay does not swallow it. The title truncates and the text column shrinks only once a control shares the row, so rows without one keep their current DOM. - BriefShareBand: a labelled copy band after the last section, where reading actually stops. All three read `briefing_share_controls` through useSharePlacement: the flag default is false, so app.daily.dev is unchanged on merge, and branch previews turn it on without GrowthBook. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The text column carried `w-full`, so it claimed the whole article and pushed the copy button past the card border. Shrinkable and greedy instead of 100% wide: same width, no overflow. Rows without a control keep `w-full` and their original DOM. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The gear shipped variant-less, so it inherited full-strength text colour and read brighter than the Tertiary copy and share buttons that now sit next to it in the header. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…psell The card wore the Plus-upsell sticker treatment — a white outer border, a 4px black inner border and the brief gradient — around what is a settings panel, so a Title2 "Customize your presidential briefing" shouted over the briefing it belongs to. One surface-float card with a subtlest border, heading down to Body bold, description to tertiary Footnote, and the "Receive via" label a step quieter so the card has one voice. The removed border-white/border-black were raw palette values that could not survive a light theme. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…not an upsell" This reverts commit d6d2913.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
snapshot-post-page-variations(#6556). Adds one internal review page,/dev/briefing-share, for the two briefing surfaces: the list at/briefingand the briefing itself.Snapshot is deliberately out. The premise behind putting it here — "a briefing link is personalized, so it is broken for the recipient" — does not survive a read of the code: a brief is a normal post at
/posts/{slug}(BriefListItem.tsx:144), so the link resolves, anduseSharePost.copyLinkalready shortens it and tags it withReferralCampaignKey.SharePost.What the page argues
hidden laptop:block(BriefPostHeaderActions.tsx:31) andBriefPostContent.tsx:357is its only caller passingshowShareButton. A working, tracked copy button exists and is invisible on tablet and mobile, where most briefings are read. Deleting one class name is the whole change./briefingrows — feat(share): briefing copy actions + personalized digest share parity #6353's control with the arrow dropped. Rows repeat and sit under a full-bleedCardLink; each extra glyph is another mis-tap target.Every variant is drawn at Desktop / Tablet / Mobile widths. Copy buttons really copy; the share arrow, settings and Generate Brief are inert.
Notes
packages/sharedchanges. The page is additive and carriesnoindex/nofollow, blocked onapp.daily.devandwww.daily.dev.🤖 Generated with Claude Code
Preview domain
https://claude-snapshot-briefing-preview.preview.app.daily.dev