Skip to content

fix(roadmap): pin the delivery title refusal - #3473

Closed
dan-petty wants to merge 1 commit into
mainfrom
fix/3368-pin-the-delivery-title-refusal
Closed

dan-petty wants to merge 1 commit into
mainfrom
fix/3368-pin-the-delivery-title-refusal

Conversation

@dan-petty

Copy link
Copy Markdown
Owner

The implement job refuses a delivery title that title_problems reports. This change adds the two cases that #3368 names and no test covered: a type the project does not declare, and a Planned item that must stop before the first push.

Closes #3368

Change: openspec/changes/archive/2026-11-04-3368-stop-a-delivery-title-that-the/

@dan-petty dan-petty added type/bug Defect, regression, or incorrect runtime behavior scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them labels Nov 4, 2026
@dan-petty
dan-petty marked this pull request as ready for review November 4, 2026 16:22
@dan-petty

Copy link
Copy Markdown
Owner Author

Evaluation for #3368 - not selected

The two cases pass because they monkeypatch devops_cli.roadmap.implement_run.delivery_title. That bypasses the real title derivation and adds two patches, which the patch ratchet discourages.

The staged case also edits no issue title in the store. It therefore does not reproduce the scenario "a person edits the issue title after staging". #3474 and #3472 do.

No CI defect found. Close in favor of #3474.

@dan-petty dan-petty closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/roadmap The roadmap jobs: intake, refine, stage, implement and the Service that runs them type/bug Defect, regression, or incorrect runtime behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(roadmap): stop a delivery title that the check refuses

1 participant