Repository navigation
feat(roadmap): let a negative search verify check more than one name - #3678
Merged
Merged
Conversation
A negative search with two names is refused as the option -e. These tests pin the form that runs git grep with one -e for each name, and the refusals of an -e value that is not a plain literal.
The negative search reads one literal. These tests pin the new shape, with a tuple of literals and a flag for the -e form.
…e gate The stage gate reads one literal of a negative search. These tests pin a hit check and a move check for each literal of the -e form.
The prompt gives one literal only. This test pins the -e form and the -- that comes before the paths.
The negative search takes one or more -e literals, each one plain, and then -- before the paths. Git matches any of them. The stage gate checks each literal for a staged hit and for a created module.
The negative search of task 3.3 used -E, which the step refuses. The search now names the four literals with one -e each.
The guide names one literal only. It now names the -e form, the -- before the paths, and the refused -E and -P.
The change for #3276 is archived with its spec deltas. The step reads repeated -e literals, and the stage gate checks each one.
This reverts commit 7e0ecef8a2d2e5738e6a17aae160a869b55df018.
The reason of a refused -e form ran past the word limit of the style rule. The reason now names the refused word and both forms in one short sentence. The test that pins the text follows the new reason.
The sentence that states the form of the negative search ran past the word limit of the style rule. It now runs as four short sentences, and keeps the same rules.
The code renamed _literal to _literals. The task names the new name.
Owner
Author
|
Test results for this pull request. Fail-to-pass: Full gate: Every row passed except two:
Review findings before this pull request. I verified the four findings. All four are correct, and this pull request fixes them.
|
dan-petty
marked this pull request as ready for review
November 5, 2026 18:37
dan-petty
pushed a commit
that referenced
this pull request
Nov 5, 2026
🤖 I have created a release *beep* *boop* --- ## [0.63.0](v0.62.7...v0.63.0) (2026-11-05) ### Features * **roadmap:** let a negative search verify check more than one name ([#3678](#3678)) ([5a4364c](5a4364c)) * **telemetry:** count the tool calls of the stage planner by outcome ([#3679](#3679)) ([45da6dd](45da6dd)) ### Bug Fixes * **ci:** count tests and specs as hardening guardrails ([#3684](#3684)) ([1d75506](1d75506)) * **security:** mask the user name of a URL with no password ([#3676](#3676)) ([bc1cd9c](bc1cd9c)) * **service:** count each GitHub request with its HTTP status ([#3686](#3686)) ([b39dcba](b39dcba)) * **telemetry:** Service counters read true across pods and repos ([#3680](#3680)) ([05544ab](05544ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: dan-petty-release[bot] <346998822+dan-petty-release[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plan that removes several names needs one check for all of them. The negative search of the implement step took one literal and no
-e, so the step refused the-Eline of task 3.3 of the #2610 plan and that group could not run.The search now also takes one or more
-eliterals, with--before the paths. Each value is a plain literal that must not start with-, and a refused value gets a reason that states the rule. The stage job applies the hit rule and the created-module rule to each literal, and a move group checks each literal. The #2610 line now uses four-eliterals. The stage prompt anddocs/TESTING.mdstate the form.The test over every active
tasks.mdmoves to #3579, because other active plans hold refused commands.Closes #3276
Change:
openspec/changes/archive/2026-11-05-3276-negative-search-accepts-repeated-e/