Skip to content

DAOS-17843 placement: correct the way JCH placement calls CRC - #16808

Merged
gnailzenh merged 9 commits into
masterfrom
shilongw/DAOS-17843
Sep 25, 2025
Merged

DAOS-17843 placement: correct the way JCH placement calls CRC#16808
gnailzenh merged 9 commits into
masterfrom
shilongw/DAOS-17843

Conversation

@wangshilong

@wangshilong wangshilong commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

The Jump Consistent Hash (JCH) placement algorithm in DAOS calls the CRC functions incorrectly, which may lead to excessive hash collisions and imbalanced data distribution.
This patch corrects how the JCH placement algorithm invokes the CRC functions.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@gnailzenh @wangshilong
DAOS-17843 placement: correct the way JCH placement calls CRC
e08754b 
The Jump Consistent Hash (JCH) placement algorithm in DAOS calls the CRC
functions incorrectly, which may lead to excessive hash collisions and
imbalanced data distribution.
This patch corrects how the JCH placement algorithm invokes the CRC functions.

Signed-off-by: Zhen Liang <zhen.liang@hpe.com>
Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
@wangshilong
wangshilong requested review from a team as code owners September 4, 2025 02:17
@github-actions

github-actions Bot commented Sep 4, 2025

Copy link
Copy Markdown

Ticket title is 'Pool rebuild stuck in pulling for 5+ hours'
Status is 'Open'
Labels: 'ALCF,hpe_cluster'
https://daosio.atlassian.net/browse/DAOS-17843

@daosbuild3

daosbuild3 commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16808/1/testReport/

Shilong Wang and others added 2 commits September 11, 2025 09:50
Shilong Wang @wangshilong
interoperability fix
6b98b7f 
Signed-off-by: Wang Shilong <shilong.wang@hpe.com>
@wangshilong
Merge branch 'master' of github.com:daos-stack/daos into shilongw/DAO…
56fbb27 
…S-17843
@wangshilong
wangshilong requested review from a team as code owners September 11, 2025 02:40
@daosbuild3

daosbuild3 commented Sep 16, 2025

Copy link
Copy Markdown
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16808/5/testReport/

@daosbuild3

daosbuild3 commented Sep 16, 2025

Copy link
Copy Markdown
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16808/5/testReport/

@daosbuild3

daosbuild3 commented Sep 16, 2025

Copy link
Copy Markdown
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16808/5/testReport/

@daosbuild3

daosbuild3 commented Sep 16, 2025

Copy link
Copy Markdown
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16808/5/testReport/

@daosbuild3

daosbuild3 commented Sep 16, 2025

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16808/5/execution/node/1316/log

@gnailzenh

gnailzenh commented Sep 18, 2025

Copy link
Copy Markdown
Collaborator

Could you rebase it and get Jeff's fix?

@wangshilong

wangshilong commented Sep 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Could you rebase it and get Jeff's fix?

Jeff's fix has been included, test is already in-progress..

gnailzenh
gnailzenh previously approved these changes Sep 19, 2025
View reviewed changes
@daosbuild3

daosbuild3 commented Sep 20, 2025

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-16808/6/testReport/

@wangshilong

wangshilong commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

Refreshed to fix a pipline bug which is exposed by this PR.

@wangshilong

wangshilong commented Sep 23, 2025

Copy link
Copy Markdown
Contributor Author

refreshed to resolve conflicts..

@daosbuild3

daosbuild3 commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16808/8/execution/node/1339/log

@gnailzenh
gnailzenh merged commit 8f589fe into master Sep 25, 2025
43 checks passed
@gnailzenh
gnailzenh deleted the shilongw/DAOS-17843 branch September 25, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liuxuezhao liuxuezhao liuxuezhao approved these changes
@gnailzenh gnailzenh gnailzenh approved these changes
@NiuYawei NiuYawei Awaiting requested review from NiuYawei
@Nasf-Fan Nasf-Fan Awaiting requested review from Nasf-Fan

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wangshilong @daosbuild3 @gnailzenh @liuxuezhao